[asterisk-dev] [Code Review] ODBC Transaction support

[Russell Bryant]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.digium.com/r/92/#review259
-----------------------------------------------------------



/trunk/res/res_odbc.c
<http://reviewboard.digium.com/r/92/#comment525>

    The channel must be locked around this API call.



/trunk/res/res_odbc.c
<http://reviewboard.digium.com/r/92/#comment526>

    I guess you'll have to update this for ast_str_opaque :-)



/trunk/res/res_odbc.c
<http://reviewboard.digium.com/r/92/#comment527>

    Since the body of this traversal is a trivial check to search for a match, it would probably be better served by ao2_callback().



/trunk/res/res_odbc.c
<http://reviewboard.digium.com/r/92/#comment528>

    The channel needs to be locked here



/trunk/res/res_odbc.c
<http://reviewboard.digium.com/r/92/#comment529>

    This will need to be updated for xmldocs


- Russell


On 2008-12-14 12:34:40, Tilghman Lesher wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.digium.com/r/92/
> -----------------------------------------------------------
> 
> (Updated 2008-12-14 12:34:40)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> This is a long running branch, meant for adding Database Transaction support to the ODBC layer.  The primary use of this is in func_odbc, though the layers provided will make it possible to support transactions in other applications, as well.
> 
> 
> Diffs
> -----
> 
>   /trunk/funcs/func_odbc.c 164082 
>   /trunk/include/asterisk/res_odbc.h 164082 
>   /trunk/res/res_odbc.c 164082 
> 
> Diff: http://reviewboard.digium.com/r/92/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Tilghman
> 
>