[asterisk-dev] [Code Review] Document Commit Message Formatting Information

[Russell Bryant]

> On 2008-12-17 17:04:14, Mark Michelson wrote:
> > /trunk/include/asterisk/doxyref.h, lines 350-362
> > <http://reviewboard.digium.com/r/96/diff/1/?file=1935#file1935line350>
> >
> >     For the sake of completeness, I'd make a note that the verbose description is not necessarily required for trivial commits along the lines of "fix the build" or "Fix spacing." Your call really.

Good suggestion, done.


> On 2008-12-17 17:04:14, Mark Michelson wrote:
> > /trunk/include/asterisk/doxyref.h, lines 374-376
> > <http://reviewboard.digium.com/r/96/diff/1/?file=1935#file1935line374>
> >
> >     "usa a tag of the form" instead of "use a of of the form"

Oops, thanks.  :-)


> On 2008-12-17 17:04:14, Mark Michelson wrote:
> > /trunk/include/asterisk/doxyref.h, lines 378-389
> > <http://reviewboard.digium.com/r/96/diff/1/?file=1935#file1935line378>
> >
> >     I'd place a note in here stating that the commit message template may be automatically generated for you if you are a Mantis admin. Point out where on a bug page to click to have this information generated.
> >     
> >     This is one of those things that seems pretty obvious to those of us who have been Mantis admins for a while, but for someone new who comes along, it's a good idea to spell this out plainly so they don't go to a lot of effort to manually fit the commit message template.

I have added info on where to find the template, so hopefully it's more clear


> On 2008-12-17 17:04:14, Mark Michelson wrote:
> > /trunk/include/asterisk/doxyref.h, lines 404-414
> > <http://reviewboard.digium.com/r/96/diff/1/?file=1935#file1935line404>
> >
> >     It may be a good idea to place a link here to the asterisk.org page with all the ins and outs of merging using svn.

done!


- Russell


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.digium.com/r/96/#review241
-----------------------------------------------------------


On 2008-12-18 07:51:27, Russell Bryant wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.digium.com/r/96/
> -----------------------------------------------------------
> 
> (Updated 2008-12-18 07:51:27)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> This patch adds a new doxygen developer documentation page that covers commit message formatting.  We have a number of special tags and such that can be used, and this documents how to use them, and what commit messages should look like in general.
> 
> The one thing that this covers that isn't done very often today is always having a one line summary at the top of the commit message, but I feel that this is something we should start doing as a standard thing.
> 
> 
> Diffs
> -----
> 
>   /trunk/include/asterisk/doxyref.h 165436 
> 
> Diff: http://reviewboard.digium.com/r/96/diff
> 
> 
> Testing
> -------
> 
> I ran "make progdocs" and viewed the resulting documentation.
> 
> 
> Thanks,
> 
> Russell
> 
>