[asterisk-dev] [Code Review] New Application: Originate

[Russell Bryant]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.digium.com/r/95/
-----------------------------------------------------------

(Updated 2008-12-17 15:51:01.960386)


Review request for Asterisk Developers.


Changes
-------

Updated diff to add ORIGINATE_STATUS result variable, per mmichelson's suggestion.


Summary
-------

This patch introduces a new application, Originate.  I made a lot of changes to the original patch, so I figured it would be worth getting another set of eyes on the code before commit.


This addresses bug 14075.
    http://bugs.digium.com/view.php?id=14075


Diffs (updated)
-----

  /trunk/CHANGES 165329 
  /trunk/apps/app_originate.c PRE-CREATION 

Diff: http://reviewboard.digium.com/r/95/diff


Testing
-------

Tested calls to 589 through 595 and got expected results.

exten => s,1,Answer
exten => s,n,MusicOnHold()

exten => 589,1,Answer
exten => 589,n,Originate(SIP/5004,exten,default,586,1)
exten => 589,n,Playback(demo-congrats)

exten => 590,1,Answer
exten => 590,n,Originate(SIP/5004,exten,default,586)
exten => 590,n,Playback(demo-congrats)

exten => 591,1,Answer
exten => 591,n,Originate(SIP/5004,exten,default)
exten => 591,n,Playback(demo-congrats)

exten => 592,1,Answer
exten => 592,n,Originate(SIP/5004,exten)
exten => 592,n,Playback(demo-congrats)

exten => 593,1,Answer
exten => 593,n,Originate(SIP/5004,app,Playback,demo-congrats)
exten => 593,n,Playback(demo-congrats)

exten => 594,1,Answer
exten => 594,n,Originate(SIP/5004,app,Echo)
exten => 594,n,Playback(demo-congrats)

exten => 595,1,Answer
exten => 595,n,Originate(SIP/5004,app)
exten => 595,n,Playback(demo-congrats)


Thanks,

Russell