[asterisk-dev] [Code Review] Add 'ignoresdpversion' option to chan_sip to support non-standard SDP behavior

[Mark Michelson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.digium.com/r/94/#review234
-----------------------------------------------------------

Ship it!


It looks correct to me! Good job updating the sample configs and CHANGES files too.

- Mark


On 2008-12-17 10:59:42, Matthew Nicholson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.digium.com/r/94/
> -----------------------------------------------------------
> 
> (Updated 2008-12-17 10:59:42)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> This patch adds a new 'ignoresdpversion' option to sip.conf.  When this is enabled (either globally or for a specific peer), chan_sip will treat any SDP data it receives as new data and update the media stream accordingly.  By default, Asterisk will only modify the media stream if the SDP session version received is different from the current SDP session version.  This option is required to interoperate with devices that have non-standard SDP session version implementations (observed by toc on the bug tracker with Microsoft OCS which always uses 0 as the session version).
> 
> 
> This addresses bug 13958.
>     http://bugs.digium.com/view.php?id=13958
> 
> 
> Diffs
> -----
> 
>   trunk/CHANGES 164941 
>   trunk/channels/chan_sip.c 164941 
>   trunk/configs/sip.conf.sample 164941 
> 
> Diff: http://reviewboard.digium.com/r/94/diff
> 
> 
> Testing
> -------
> 
> Toc on the bug tracker tested this patch and I made sure it compiled with --enable-dev-mode.
> 
> 
> Thanks,
> 
> Matthew
> 
>