[asterisk-dev] [Code Review] Reference Count Handling of SIP dialogs in Session Timer Processing

[Russell Bryant]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.digium.com/r/17/
-----------------------------------------------------------

(Updated 2008-12-16 08:09:43.833535)


Review request for Asterisk Developers.


Changes
-------

Just removing the "digium_swdev" group from this review so that I can delete the group.


Summary
-------

I have been working on another reference count handling audit in chan_sip.  I have found a number of problems.  Some I have already fixed.  Some I have documented.

This patch addresses the lack of reference counting on the sip_pvt structure for scheduler entries related to SIP session timer processing.  I think I've got it right, but a sanity check would be good, as I wrote this at an insane hour in the morning.


Diffs
-----

  /trunk/channels/chan_sip.c 153123 

Diff: http://reviewboard.digium.com/r/17/diff


Testing
-------

The "make" test passed


Thanks,

Russell