[asterisk-dev] [Code Review] Make 'core show sysinfo' work on systems that dont have sysinfo but do have sysctl (Like OpenBSD)

Russell Bryant russell at digium.com
Sun Dec 14 10:48:17 CST 2008


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.digium.com/r/91/#review223
-----------------------------------------------------------

Ship it!


Other that one other tiny thing that I missed the first time, this looks fine.

Thanks for the contribution!



trunk/main/asterisk.c
<http://reviewboard.digium.com/r/91/#comment452>

    Use ast_free()



trunk/main/asterisk.c
<http://reviewboard.digium.com/r/91/#comment453>

    Use ast_free()


- Russell


On 2008-12-14 10:18:54, Michiel van Baak wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.digium.com/r/91/
> -----------------------------------------------------------
> 
> (Updated 2008-12-14 10:18:54)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> OpenBSD (and some others) dont have the sysinfo functionality found in Linux.
> The same information can be found using sysctl on those systems.
> 
> 
> This addresses bug 13433.
>     http://bugs.digium.com/view.php?id=13433
> 
> 
> Diffs
> -----
> 
>   trunk/configure 164138 
>   trunk/configure.ac 164138 
>   trunk/include/asterisk/autoconfig.h.in 164138 
>   trunk/main/asterisk.c 164138 
> 
> Diff: http://reviewboard.digium.com/r/91/diff
> 
> 
> Testing
> -------
> 
> compiles and works on OpenBSD 4.4 amd64
> 
> 
> Thanks,
> 
> Michiel
> 
>




More information about the asterisk-dev mailing list