[asterisk-dev] [Code Review] Update timing to deal with multiple ranges and per-minute accuracy

[Mark Michelson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.digium.com/r/53/#review217
-----------------------------------------------------------



trunk/main/pbx.c
<http://reviewboard.digium.com/r/53/#comment417>

    You did not address the point I raised about improving the indentation here. It's strictly a cosmetic improvement I'm suggesting, so I can understand if you don't want to implement it. I'm just pointing it out since your update said that suggested improvements had been implemented.



trunk/main/pbx.c
<http://reviewboard.digium.com/r/53/#comment416>

    You did not address the duplicate setting of the LSB of mask here in the case where a range wraps around.


- Mark


On 2008-12-12 17:09:49, Tilghman Lesher wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.digium.com/r/53/
> -----------------------------------------------------------
> 
> (Updated 2008-12-12 17:09:49)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> The timing API was mis-documented in TFOT to allow multiple ranges and single hours, through the use of the '&'.  This patch updates the code to make TFOT correct.  Also, it sets times to be accurate down to the minute, instead of the current 2-minute precision that confuses so many people.
> 
> 
> Diffs
> -----
> 
>   trunk/include/asterisk/pbx.h 163761 
>   trunk/main/pbx.c 163761 
> 
> Diff: http://reviewboard.digium.com/r/53/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Tilghman
> 
>