[asterisk-dev] [svn-commits] tilghman: branch 1.4 r162348 - /branches/1.4/apps/app_voicemail.c

[Mark Michelson]

SVN commits to the Digium repositories wrote:
> Author: tilghman
> Date: Tue Dec  9 15:53:25 2008
> New Revision: 162348
> 
> URL: http://svn.digium.com/view/asterisk?view=rev&rev=162348
> Log:
> We appear to have documented tz= in the [general] section of voicemail.conf,
> without actually having implemented it.  Oops.
> (Reported by Olivier on the -users list)
> 
> Modified:
>     branches/1.4/apps/app_voicemail.c
> 
> Modified: branches/1.4/apps/app_voicemail.c
> URL: http://svn.digium.com/view/asterisk/branches/1.4/apps/app_voicemail.c?view=diff&rev=162348&r1=162347&r2=162348
> ==============================================================================
> --- branches/1.4/apps/app_voicemail.c (original)
> +++ branches/1.4/apps/app_voicemail.c Tue Dec  9 15:53:25 2008
> @@ -537,6 +537,7 @@
>  
>  static AST_LIST_HEAD_STATIC(users, ast_vm_user);
>  static AST_LIST_HEAD_STATIC(zones, vm_zone);
> +static char zonetag[80];
>  static int maxsilence;
>  static int maxmsg;
>  static int silencethreshold = 128;
> @@ -602,6 +603,7 @@
>  	ast_copy_string(vmu->callback, callcontext, sizeof(vmu->callback));
>  	ast_copy_string(vmu->dialout, dialcontext, sizeof(vmu->dialout));
>  	ast_copy_string(vmu->exit, exitcontext, sizeof(vmu->exit));
> +	ast_copy_string(vmu->zonetag, zonetag, sizeof(vmu->zonetag));
>  	if (maxmsg)
>  		vmu->maxmsg = maxmsg;
>  	vmu->volgain = volgain;
> @@ -8665,6 +8667,9 @@
>  				tmpread = tmpwrite + 1;
>  			}
>  		}
> +		if ((s = ast_variable_retrieve(cfg, "general", "zonetag"))) {
> +			ast_copy_string(zonetag, s, sizeof(zonetag));
> +		}
>  		if ((s = ast_variable_retrieve(cfg, "general", "pagersubject")))
>  			pagersubject = ast_strdup(s);
>  		if ((s = ast_variable_retrieve(cfg, "general", "pagerbody"))) {
> 
> 
> _______________________________________________
> --Bandwidth and Colocation Provided by http://www.api-digital.com--
> 
> svn-commits mailing list
> To UNSUBSCRIBE or update options visit:
>    http://lists.digium.com/mailman/listinfo/svn-commits

If we documented the option as tz, then why is the patch searching for an option 
called "zonetag?" Either the documentation needs to be updated to show that 
"zonetag" is the name of the option, or the general section option also needs to 
be called "tz." Personally, I prefer the latter.

Mark Michelson