[asterisk-dev] [Code Review] Make the parameter separator backward compatible, and error messages more consistent.

[Eliel Sardañons]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.digium.com/r/79/
-----------------------------------------------------------

(Updated 2008-12-09 04:46:09.732516)


Review request for Asterisk Developers.


Changes
-------

- Start using THREADSTORAGE for the return values.
- Remove the backward compatibility structure (app_delim [compat]) based on kpfleming and russellb comments on irc.
- Put a comment describing that the parameter delimiter must be a single character.
- Change pbx_lua to use the STANDARD_DELIM instead of the hardcoded ",".


Summary
-------

This patch implements an asterisk.conf [compat] option called app_delim, to make applications and functions parameter delimiter backward compatible. if app_delim < 1.5 then, then app/fun delimited should be | (pipe), otherwise it should be "," comma.
Also there are a number of functions that where not using STANDARD_APP_ARG to parse the app/fun parameters, so, that was changed to use AST_STANDARD_APP_DELIM.
When printing error messages, we where printing the "syntax" with a hardcoded parameter separator, now the syntax being printed is the one generated with the xml documentation, so the error messages will be consistent with the actual parameter separator, and also with the actual app/fun syntax.


Diffs (updated)
-----

  /trunk/apps/app_dial.c 161945 
  /trunk/apps/app_macro.c 161945 
  /trunk/apps/app_meetme.c 161945 
  /trunk/apps/app_readfile.c 161945 
  /trunk/funcs/func_callerid.c 161945 
  /trunk/funcs/func_cut.c 161945 
  /trunk/funcs/func_env.c 161945 
  /trunk/funcs/func_realtime.c 161945 
  /trunk/funcs/func_strings.c 161945 
  /trunk/include/asterisk/app.h 161945 
  /trunk/include/asterisk/pbx.h 161945 
  /trunk/main/pbx.c 161945 
  /trunk/main/xmldoc.c 161945 
  /trunk/pbx/pbx_lua.c 161945 

Diff: http://reviewboard.digium.com/r/79/diff


Testing
-------

Developer testing.


Thanks,

Eliel