[asterisk-dev] [Code Review] Play a courtesy tone to the target of a SIP attended transfer when the transfer completes

[Mark Michelson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.digium.com/r/81/#review179
-----------------------------------------------------------



/trunk/channels/chan_sip.c
<http://reviewboard.digium.com/r/81/#comment340>

    You're playing "beep" explicitly instead of xfersound. This seems to contradict the statement in CHANGES


- Mark


On 2008-12-05 12:33:25, Terry Wilson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.digium.com/r/81/
> -----------------------------------------------------------
> 
> (Updated 2008-12-05 12:33:25)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> The sample sip.conf shows setting ATTENDED_TRANSFER_COMPLETE_SOUND in a setvar example.  This setting only makes a difference if you are using builtin transfers.  This patch enables native SIP attended transfers to do the same thing.
> 
> 
> Diffs
> -----
> 
>   /trunk/CHANGES 160390 
>   /trunk/channels/chan_sip.c 160390 
> 
> Diff: http://reviewboard.digium.com/r/81/diff
> 
> 
> Testing
> -------
> 
> I have tested making the transfer with and with out ATTENED_TRANSFER_COMPLETE_SOUND set.  I have also tried using both regular attended transfers and blonde transfers* and all behave as expected.
> 
> * mmichelson coined the term "blonde transfer" to describe the act of completing an attended transfer while the target is still ringing instead of using a blind transfer like Nature intended
> 
> 
> Thanks,
> 
> Terry
> 
>