[asterisk-dev] 1.6.0.3 app_fax - without typo

[Steve Underwood]

Karl Fife wrote:
> Sorry, this should have been its own post:
>  
> The following app_fax bug did not seem to be fixed in 1.6.0.2:
> 'http://bugs.digium.com/file_download.php?file_id=20425&type=bug'
>  
> I had to patch it again in 1.6.0.2, just like 1.6.0.1.  will it be 
> fixed in 1.6.0.3 or will it have to wait till 1.6.1.x?
>  
> -Karl
That's a rather poor patch. The latest spandsp has changes to reduce the 
need to probe inside its internal structures (as part of working towards 
eliminating that need). Rather than use

    t30state=&t38.t30_state;
    t38state=&t38.t38;

its more appropriate to use

    t30state = t38_terminal_get_t30_state(&t38);
    t38state = t38_terminal_get_t38_core_state(&t38);

and similarly to access the underlying t30 context for an audio fax context use.

    t30state = fax_get_t30_state(&fax);

Regards,
Steve