[asterisk-dev] [Code Review] manager.c does not compile on OpenBSD anymore. This patch fixes it.

[Russell Bryant]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.digium.com/r/66/#review165
-----------------------------------------------------------

Ship it!


Looks good.  Put a space after the cast, though.  :-)

- Russell


On 2008-12-01 04:49:32, Michiel van Baak wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.digium.com/r/66/
> -----------------------------------------------------------
> 
> (Updated 2008-12-01 04:49:32)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> manager.c has a call to ast_channel_alloc with NULL as last argument.
> This last argument should be a pointer. And since NULL is not really a pointer compile fails on OpenBSD.
> 
> The attached patch fixes it in 1.4
> in trunk and the 1.6.X branches I think it's better to fix it by replacing NULL with SENTINEL in this call.
> 
> 
> Diffs
> -----
> 
>   branches/1.4/main/manager.c 159896 
> 
> Diff: http://reviewboard.digium.com/r/66/diff
> 
> 
> Testing
> -------
> 
> Compiles and the manager works with this patch attached on OpenBSD 4.4
> 
> 
> Thanks,
> 
> Michiel
> 
>