[asterisk-dev] [asterisk-commits] qwell: trunk r82800 - in /trunk: apps/app_queue.c configs/queues.conf.sample

[Mark Michelson]

Mark Michelson wrote:
> Kevin P. Fleming wrote:
>   
>> SVN commits to the Asterisk project wrote:
>>
>>   
>>     
>>> +		if (update_cdr && qe->chan->cdr) 
>>> +			ast_copy_string(qe->chan->cdr->dstchannel, member->membername, sizeof(qe->chan->cdr->dstchannel));
>>>     
>>>       
>> This is buggy; member->membername could be an empty string, it is only
>> populated if a member name is specified. For static members there is no
>> membername, and so if 'updatecdr' is enabled this will result in a
>> broken CDR entry.
>>
>> This code either needs to use member->interface if member->membername is
>> empty, or we need to simplify the code in app_queue and just populate
>> ->membername with a copy of ->interface if no member name is provided
>> when the member is added to the queue.
>>
>>   
>>     
> Correct me if I'm wrong, but I believe that the membername field of a 
> member will be set to it's interface if no name is specified. There may 
> be some exception, but I'm pretty certain this happens for all types of 
> members.
>
> Mark!
>   
I just checked, and in 1.4 and trunk, static members, realtime members, 
manager-added members, CLI-added members, and dialplan-added members 
will all have their membername set to their interface if no membername 
is specified.

Mark!