[asterisk-dev] [svn-commits] tilghman: branch 1.4 r87120 - /branches/1.4/funcs/func_curl.c

[Tilghman Lesher]

On Friday 26 October 2007 14:56:19 Russell Bryant wrote:
> SVN commits to the Digium repositories wrote:
> > Author: tilghman
> > Date: Fri Oct 26 08:54:30 2007
> > New Revision: 87120
> >
> > URL: http://svn.digium.com/view/asterisk?view=rev&rev=87120
> > Log:
> > The addition of autoservice to func_curl additionally made func_curl
> > dependent on the existence of a channel, with no real reason.  This
> > should make func_curl once again work without a channel.
> > Reported by jmls.
> > Fixed by tilghman.
> > Closes issue #11090
>
> I thought we made a change in main/pbx.c such that dialplan functions would
> _always_ be called with a channel.  If there wasn't a real channel
> available, a fake one would be used.  What case wasn't covered?

I believe you're mistaken.  I don't see any code in pbx.c where it is assured
that a channel cannot be NULL when calling functions.  I checked both
ast_func_read and pbx_substitute_variables_helper_full.

-- 
Tilghman