[asterisk-dev] Janitor project ast_module_load_result ??

[Eliel Sardanons]

This are load_module()'s return values, I am not changing nothing,  this is
just the way "it should be", read chan_sip.c  and you will notice how
'return AST_MODULE_LOAD_SUCCESS' is being used.
But if you take a look at some modules (chan_gtalk.c), they don't use this
return values defined in the enum, they use just the values "0, -1,1,2" and
we should change everything to start using the names
AST_MODULE_LOAD_SUCCESS, *_DECLIE, *_SKIP, etc.

Sample:
- return 0;
+ return AST_MODULE_LOAD_SUCCESS;


On 10/25/07, Tzafrir Cohen <tzafrir.cohen at xorcom.com> wrote:
>
> On Thu, Oct 25, 2007 at 02:09:02PM -0300, Eliel Sardanons wrote:
> > I think we could start a new janitor project to replace every 'return'
> on
> > load_module's with:
> >
> > enum ast_module_load_result {
> >         AST_MODULE_LOAD_SUCCESS = 0,    /*!< Module loaded and
> configured */
> >         AST_MODULE_LOAD_DECLINE = 1,    /*!< Module is not configured */
> >         AST_MODULE_LOAD_SKIP = 2,       /*!< Module was skipped for some
> > reason */
> >         AST_MODULE_LOAD_FAILURE = -1,   /*!< Module could not be loaded
> > properly */
> > };
>
> What do those return values mean? Does a return value of -1 mean that
> Asterisk should die?
>
> --
>                Tzafrir Cohen
> icq#16849755              jabber:tzafrir.cohen at xorcom.com
> +972-50-7952406           mailto:tzafrir.cohen at xorcom.com
> http://www.xorcom.com  iax:guest at local.xorcom.com/tzafrir
>
> _______________________________________________
> --Bandwidth and Colocation Provided by http://www.api-digital.com--
>
> asterisk-dev mailing list
> To UNSUBSCRIBE or update options visit:
>    http://lists.digium.com/mailman/listinfo/asterisk-dev
>



-- 
Eliel Sardañons
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.digium.com/pipermail/asterisk-dev/attachments/20071025/06c220b2/attachment.htm