[asterisk-dev] Patch CLI app_meetme.c - meetme concise

[Tilghman Lesher]

On Wednesday 24 October 2007 08:58:02 Atis Lezdins wrote:
> On Wednesday 24 October 2007 16:37:25 you wrote:
> > On Wednesday 24 October 2007 08:22:37 Atis Lezdins wrote:
> > > On Wednesday 24 October 2007 15:54:36 Tilghman Lesher wrote:
> > > > On Wednesday 24 October 2007 07:09:10 Sean Bright wrote:
> > > > > On 10/24/07, Julien Thomas <omk8421 at gmail.com> wrote:
> > > > > > Hi,
> > > > > >
> > > > > > I am not familiar with SVN and I have never contributed in a big
> > > > > > project. Anyway, I have just added a "concise" option to the
> > > > > > "meetme" command of app_meetme in order to parse results obtained
> > > > > > through the manager in an easier way.
> > > > > >
> > > > > > Here is the attached patch, based of the last SVN version. There
> > > > > > is support for the tab completion, and the concise option use "!"
> > > > > > to separate each field of the list (e.g. just like "meetme list
> > > > > > 110001 concise" would do).
> > > > >
> > > > > The Asterisk developers need to ensure that your code submissions
> > > > > are properly disclaimed before reviewing them.  You will want to
> > > > > submit your patch to Mantis (http://bugs.digium.com/) but you will
> > > > > first want to review the submission guidelines at:
> > > > >
> > > > >     http://asterisk.org/developers/bug-guidelines
> > > > >
> > > > > This covers everything you need to know about submitting code to
> > > > > the Asterisk project.
> > > >
> > > > Also, I really don't like concise commands created for the CLI.  If
> > > > you want output to be machine parseable, you shouldn't be making a
> > > > CLI command at all -- make a native Manager command, instead.  This
> > > > will additionally help administrators to segregate privileges on AMI
> > > > to do only what each user really needs to do.
> > >
> > > Are there such commands? Can't find anything on voip-info except Queues
> > > (but it doesn't seem to provide concise output).
> >
> > 'show channels concise' is one such example.
>
> But "show channels concise" is used trough "Command" action - so it's still
> CLI function called. That means - adding "meetme concise" would allow to
> use that from manager. As i understand - you are talking about dedicated
> manager actions for acquiring status on channels/queues/meetme. Or i didn't
> get it?

Correct, I would prefer if people who wanted all of those bits of information
to use native manager commands, rather than shoehorning all of that info
into a CLI command.

I added MeetmeList in trunk for this purpose (thus negating the need to do a
corresponding CLI command from the manager).


-- 
Tilghman