[asterisk-dev] [asterisk-commits] tilghman: trunk r90157 - /trunk/include/asterisk/lock.h

[Tilghman Lesher]

On Thursday 29 November 2007 11:46:07 Kevin P. Fleming wrote:
> SVN commits to the Asterisk project wrote:
> > Modified: trunk/include/asterisk/lock.h
> > URL:
> > http://svn.digium.com/view/asterisk/trunk/include/asterisk/lock.h?view=di
> >ff&rev=90157&r1=90156&r2=90157
> > =========================================================================
> >===== --- trunk/include/asterisk/lock.h (original)
> > +++ trunk/include/asterisk/lock.h Thu Nov 29 11:42:21 2007
> > @@ -113,6 +113,8 @@
> >                               { PTHREAD_MUTEX_INIT_VALUE, 0, { NULL }, {
> > 0 }, 0, { NULL }, { 0 }, PTHREAD_MUTEX_INIT_VALUE }
> >
> >  #define AST_MAX_REENTRANCY 10
> > +
> > +struct ast_channel;
> >
> >  struct ast_mutex_info {
> >  	pthread_mutex_t mutex;
>
> This should not be necessary, as this forward declaration already
> appears in asterisk.h. Is there a module that includes lock.h but not
> asterisk.h?

utils/astman.c was the culprit.  The real issue is that the include file was
declaring some prototypes with the 'struct ast_channel *' parameter, but the
struct itself was not declared.  Rather than including a file that astman.c
does not need, I figured that giving it a declaration to make the warning go
away was the better thing to do.

-- 
Tilghman