[asterisk-dev] [svn-commits] rizzo: trunk r89426 - in /trunk: include/ include/asterisk/ utils/

Luigi Rizzo rizzo at icir.org
Mon Nov 19 14:01:48 CST 2007


On Mon, Nov 19, 2007 at 08:47:09PM +0100, Johansson Olle E wrote:
> 
> 19 nov 2007 kl. 20.36 skrev SVN commits to the Digium repositories:
> 
> > Author: rizzo
> > Date: Mon Nov 19 13:36:32 2007
> > New Revision: 89426
> >
> > URL: http://svn.digium.com/view/asterisk?view=rev&rev=89426
> > Log:
> > move the declaration of struct ast_channel ast_frame and ast_module
> > to compat.h so it is always available - hopefully this will let
> > us reduce the number of inclusions of channel.h and frame.h
> >
> Well, at some point you start removing stuff to optimize so hard so  
> you'll end
> up obfuscating instead. Not having ast_channel declared in channel.h  
> doesn't make
> any sense at all to me, just adding to the confusion.

i didn't even touch channel.h !

in any case channel.h contains the full definition of the stucture, i.e.

	struct ast_channel { ... a ton of fields ... };

what i moved (from asterisk.h to compat.h) is only the forward declaration,

	struct ast_channel;	/* opaque type at this point */

cheers
luigi



More information about the asterisk-dev mailing list