[asterisk-dev] [asterisk-commits] rizzo: trunk r89379 - /trunk/include/asterisk/network.h

Simon Perreault simon.perreault at viagenie.ca
Sat Nov 17 08:14:15 CST 2007


On Saturday 17 November 2007 09:00:24 SVN commits to the Asterisk project 
wrote:
> Author: rizzo
> Date: Sat Nov 17 08:00:24 2007
> New Revision: 89379
>
> +/*! \brief Compares the source address and port of two sockaddr_in */
> +static force_inline int inaddrcmp(const struct sockaddr_in *sin1, const
> struct sockaddr_in *sin2) +{
> +        return ((sin1->sin_addr.s_addr != sin2->sin_addr.s_addr)
> +                || (sin1->sin_port != sin2->sin_port));
> +}

I don't understand why you copied this here. Is your network.h a compatibility 
header, or does it replace netsock.h?

Overall I really don't like this new header, I think it looks too much like 
everything.h.



More information about the asterisk-dev mailing list