[asterisk-dev] [asterisk-commits] mmichelson: branch 1.4 r89205 - /branches/1.4/apps/app_mixmonitor.c

Mark Michelson mmichelson at digium.com
Tue Nov 13 10:00:41 CST 2007

Kevin P. Fleming wrote:
> SVN commits to the Asterisk project wrote:
>> URL: http://svn.digium.com/view/asterisk?view=rev&rev=89205
>> Log:
>> Some sanity checking for MixMonitor. If only 1 argument is given, then the args.options
>> and args.post_process strings are uninitialized and could contain garbage. This change
>> handles this situation properly by only using arguments that we have parsed.
> I don't believe this is correct; one of the first things that
> ast_app_separate_args() does is to memset() the entire args array to
> zeros; this was done so that applications could just check for any
> specific argument being non-NULL without having to check the argument
> count as well.

I made this change after seeing that mixmonitor->post_process was getting 
populated with junk. As it turns out, this fix didn't do the trick, but my next 
commit, (trunk revision 89207) did. I will go ahead and revert revision 89205 
and 89206.


More information about the asterisk-dev mailing list