[asterisk-dev] asterisk-gui not recognizing codec_g729a, with patch

[Brandon Kruse]

I also need to apply the fix for embedded codec modules.

Where they do not show up as codec_ulaw.so but rather just codec_ulaw

Thanks!

-bk
----- Original Message -----
From: "Pari Nannapaneni" <pari at digium.com>
To: "Asterisk Developers Mailing List" <asterisk-dev at lists.digium.com>
Sent: Friday, November 9, 2007 11:28:07 AM (GMT-0800) America/Los_Angeles
Subject: Re: [asterisk-dev] asterisk-gui not recognizing codec_g729a, with patch

Hi Jim,

Thanks for the patch.
btw, there is a asterisk-gui mailing list for gui related stuff.

thanks
-pari




----- Original Message -----
From: "Jim Capp" <jcapp at anteil.com>
To: "Asterisk Developers Mailing List" <asterisk-dev at lists.digium.com>
Sent: Friday, November 9, 2007 1:13:11 PM (GMT-0600) America/Chicago
Subject: [asterisk-dev] asterisk-gui not recognizing codec_g729a, with patch

Hi Folks,

     I ran into a problem where the g729 codec was not being listed as
an option in the Codec Preferences pop-up.  I narrowed the problem down
to CODECSETTINGS.selectbox_add() looking for 'g729' whereas
load_codecs_fromast() returns 'g729a' for the Digium G729 codec.

I checked asterisk-gui/branches/1.4 and asterisk-gui/trunk and could not
find any recent commits that led me to believe this was being addressed.

I patched load_codecs_fromast() to substitute 'g729' for 'g729a' and
have enclosed this patch.  If I had write access to a trunk, I'd commit
it myself.  But since no ones knows me (yet), I am submitting this patch
for review.

================================================================================================================================
--- /usr/src/asterisk-gui/config/users.html     2007-11-09
13:34:37.000000000 -0500
+++ users.html  2007-11-09 13:59:43.000000000 -0500
@@ -287,6 +287,9 @@
                                        if(resp[i][1][0] == "a") {
                                                continue; /* codec is a_mu, alaw to mulaw direct codec/decoder, not a codec preference. */
                                        }
+                                       if(resp[i][1][0] == "g729a") {
+                                               resp[i][1][0] = "g729"; /* g729a needs to be reported as g729 in order to be recognized */
+                                       }
                                                allcodecs[i] = resp[i][1][0];
                                }
                        }
================================================================================================================================

Cheers,

Jim



_______________________________________________
--Bandwidth and Colocation Provided by http://www.api-digital.com--

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev


_______________________________________________
--Bandwidth and Colocation Provided by http://www.api-digital.com--

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev