[asterisk-dev] Re: russell: trunk r65968 - in /trunk: apps/ channels/ include/asterisk/ main/ pbx/

[Tony Mountifield]

In article <4656F1B4.3040507 at digium.com>,
Russell Bryant <russell at digium.com> wrote:
> Tony Mountifield wrote:
> > Scanning through the patch, this was the only instance I saw that passed
> > a pointer to an attr as the second arg instead of NULL.
> > 
> > Is there any reason the attr is part of the conf structure? It just appears
> > to get inited and destroyed in the same way as a temporary one would, and
> > every other call to ast_pthread_create_background() was content to let it
> > use a local temporary attr.
> 
> The argument is there in case someone wants to use the API call but set more 
> thread attributes than just the detached attribute.  It's true that there aren't 
> many places in the code that use it today, but it just seemed like the right 
> thing to do.

OK, cool. I can see the use of a passed-in attr struct.

I guess the question remains about why meetme has attr in the conf structure,
when it is still inited just before the call and destroyed just after.

Cheers
Tony
-- 
Tony Mountifield
Work: tony at softins.co.uk - http://www.softins.co.uk
Play: tony at mountifield.org - http://tony.mountifield.org