[asterisk-dev] [asterisk-commits] russell: trunk r72701 - in /trunk: ./ include/asterisk/ main/
russell at digium.com
Fri Jun 29 16:18:58 CDT 2007
Luigi Rizzo wrote:
> Hmmm... not 100% sure, but doesn't this kill HTTPS support, which
> requires to go through the fwrite() interface so it can use the
> encryption/decryption filter installed by fopencookie()/funopen() ?
You are absolutely correct. Oops ...
> Frankly, I believe sendfile() is totally overkill here.
> This is asterisk, not a busy web server where you want to optimize
> large file transfers.
> Surely the use of bounded size buffers is a worthwhile approach,
> but i'd suggest to just fix that part and get rid of sendfile.
That's fair. I'll fix it up now.
Thanks for the feedback,
More information about the asterisk-dev