[asterisk-dev] Re: [svn-commits] crichter: branch 1.2 r67209 - in /branches/1.2/channels: ./ misdn/

[Christian]

Jason Parker wrote:
> ----- svn-commits at lists.digium.com wrote:
>   
>> Author: crichter
>> Date: Tue Jun  5 05:05:45 2007
>> New Revision: 67209
>>
>> URL: http://svn.digium.com/view/asterisk?view=rev&rev=67209
>> Log:
>> added possibility to deactivate bridging per port
>>
>> Modified:
>>     branches/1.2/channels/chan_misdn.c
>>     branches/1.2/channels/misdn/chan_misdn_config.h
>>     branches/1.2/channels/misdn_config.c
>>
>> Modified: branches/1.2/channels/misdn/chan_misdn_config.h
>> URL:
>> http://svn.digium.com/view/asterisk/branches/1.2/channels/misdn/chan_misdn_config.h?view=diff&rev=67209&r1=67208&r2=67209
>> ==============================================================================
>> --- branches/1.2/channels/misdn/chan_misdn_config.h (original)
>> +++ branches/1.2/channels/misdn/chan_misdn_config.h Tue Jun  5
>> 05:05:45 2007
>> @@ -58,6 +58,7 @@
>>  	MISDN_CFG_NEED_MORE_INFOS,     /* bool */
>>  	MISDN_CFG_NOAUTORESPOND_ON_SETUP,     /* bool */
>>  	MISDN_CFG_NTTIMEOUT,     /* bool */
>> +	MISDN_CFG_BRIDGING,              /* int */
>>  	MISDN_CFG_JITTERBUFFER,              /* int */
>>  	MISDN_CFG_JITTERBUFFER_UPPER_THRESHOLD,              /* int */
>>  	MISDN_CFG_CALLGROUP,           /* ast_group_t */
>>
>> Modified: branches/1.2/channels/misdn_config.c
>> URL:
>> http://svn.digium.com/view/asterisk/branches/1.2/channels/misdn_config.c?view=diff&rev=67209&r1=67208&r2=67209
>> ==============================================================================
>> --- branches/1.2/channels/misdn_config.c (original)
>> +++ branches/1.2/channels/misdn_config.c Tue Jun  5 05:05:45 2007
>> @@ -119,6 +119,7 @@
>>  	{ "need_more_infos", MISDN_CFG_NEED_MORE_INFOS, MISDN_CTYPE_BOOL,
>> "0", NONE },
>>  	{ "noautorespond_on_setup", MISDN_CFG_NOAUTORESPOND_ON_SETUP,
>> MISDN_CTYPE_BOOL, "0", NONE },
>>  	{ "nttimeout", MISDN_CFG_NTTIMEOUT, MISDN_CTYPE_BOOL, "no", NONE },
>> +	{ "bridging", MISDN_CFG_BRIDGING, MISDN_CTYPE_BOOL, "yes", NONE },
>>  	{ "jitterbuffer", MISDN_CFG_JITTERBUFFER, MISDN_CTYPE_INT, "4000",
>> NONE },
>>  	{ "jitterbuffer_upper_threshold",
>> MISDN_CFG_JITTERBUFFER_UPPER_THRESHOLD, MISDN_CTYPE_INT, "0", NONE },
>>  	{ "callgroup", MISDN_CFG_CALLGROUP, MISDN_CTYPE_ASTGROUP,
>> NO_DEFAULT, NONE },
>>
>>     
>
> I see here you're specifying MISDN_CFG_BRIDGING as MISDN_CTYPE_BOOL, but in chan_misdn_config.h, you're calling it an int in the comments - I'm not sure which is correct, but this could easily cause confusion (on second glance, it looks like the same is also true for MISDN_CFG_NTTIMEOUT).
>   
you're right, that's a copy and paste issue.