[asterisk-dev] plea for more verbose commit messages (Re: [asterisk-commits] file: branch 1.4 r75712 - in /branches/1.4: apps/ channels/ pbx/)

[Mark Michelson]

Luigi Rizzo wrote:
> On Wed, Jul 18, 2007 at 08:00:23PM -0000, SVN commits to the Asterisk project wrote:
>   
>> Author: file
>> Date: Wed Jul 18 15:00:23 2007
>> New Revision: 75712
>>
>> URL: http://svn.digium.com/view/asterisk?view=rev&rev=75712
>> Log:
>> Backport GCC 4.2 fixes. Without these Asterisk won't build under devmode using GCC 4.2.
>>     
>
> commit messages are also a way for others to learn something from your
> experience. So I would like to encourage committers to be a bit
> more verbose in their log messages, especially if you think the
> issues might have an impact on other code (eg. third party stuff,
> or patches yet to be committed, etc.)
>
> For instance, in this case it might be useful to know what gcc 4.2 was
> complaining about, as e.g. the previous code in app_voicemail.c
> seemed correct. Perhaps uninitialized variables ? Why then previous
> compilers did not complain ? Does it depend on the -O level or
> is it because of a gcc 4.2 bug ?
>   

I believe the changes made were in reference to issue #10226 on the 
bugtracker.  It has more details regarding which warnings were coming up 
in gcc 4.2.

Mark!