[asterisk-dev] ast_flags now uint64_t ? should it be reverted ?

Kevin P. Fleming kpfleming at digium.com
Wed Jul 18 13:22:47 CDT 2007


Steve Murphy wrote:

> But I agree with you-- the principle "minimal change" seems better; what
> if I
> created an analog to ast_flags, like ast_flags64, and a few APP_ARG
> alternates that would use 64-bit flags, that apps with over 32 flags
> (just dial, for now), could use, and use it only in dial, and revert
> everything else back to normal?

If this change was made only to support ast_parseoptions() needing to be
able to handle more than 32 option flags, then we should find a way to
change it so that only ast_parseoptions() is affected.

If that means creating a special structure type (analogous to ast_flags)
that is only used by ast_parseoptions() and then macros to access the
flags in that structure, that would probably be a better solution.
However, this would need to be done by creating a new version of
ast_parseoptions(), so that all the existing users don't have to be
modified.

-- 
Kevin P. Fleming
Director of Software Technologies
Digium, Inc. - "The Genuine Asterisk Experience" (TM)



More information about the asterisk-dev mailing list