[asterisk-dev] RFC: chan_sip.c code cleanup for better NAT support (including stun)

[John Todd]

At 7:37 AM -0500 2007/7/18, Tilghman Lesher wrote:
>On Wednesday 18 July 2007, Luigi Rizzo wrote:
>>  I would like to merge into trunk at least (and later, possibly
>>  also into 1.4 if considered useful) some changes aimed at better
>>  operation when asterisk is behind a NAT.
>
><snip>
>
>>  The functional changes should be completely backward compatible
>>  (except possibly for bugs, but i am not aware of any).
>>  However, since i don't know whether some incompatibilities could
>>  come out, I prefer to do the work in trunk and merge into 1.4 only
>>  when it is complete and we know that there are no surprises.
>>
>>  Let me know if you have objections.
>
>Given that these are all optimizations, they should go into trunk only
>and not into 1.4 at all (unless one of them fixes a definite bug in 1.4).
>
>--
>Tilghman
>

I agree with Tilghman.  These changes seem to be a good idea, but 
they do introduce quite a few "new" concepts, and I'd be more 
comfortable leaving them in TRUNK and not in 1.4.  The only exception 
to this would be some of the clarifying documentation notes in the 
sip.conf file that you've made, which are a big improvement on 
clarify of function for some existing features.

JT