[asterisk-dev] Re: [asterisk-commits] russell: branch 1.4 r52611 - /branches/1.4/main/manager.c

[Russell Bryant]

Luigi Rizzo wrote:
> On Mon, Jan 29, 2007 at 08:39:21PM -0000, asterisk-commits at lists.digium.com wrote:
>> Author: russell
>> Date: Mon Jan 29 14:39:20 2007
>> New Revision: 52611
>>
>> URL: http://svn.digium.com/view/asterisk?view=rev&rev=52611
>> Log:
>> The session lock can not be held while calling action callbacks.  If so, then
>> when the WaitEvent callback gets called, then no event can happen because the
>> session can't be locked by another thread.  Also, the session needs to be
>> locked in the HTTP callback when it reads out the output string.  This fixes
>> the deadlock reported in both 8711 and 8934.
>> Regarding issue 8711, there still may be an issue.  If there is a second action
>> requested before the processing of the first action is finished, there could
>> still be some corruption of the output string buffer used to build the result.
>> (issue #8711, #8934)
> 
> haven't followed in detail the bug reports, but was wondering if
> trunk is also affected (since i changed a few things there both in
> manager.c and http.c...)

Yes, I have already made the relevant changes in trunk.  8934, which was 
only about the deadlock, was an issue in trunk, but only because I made 
the same mistake in both 1.4 and trunk when trying to fix the original 
crash problem reported in 8711.

I may have the crash fixed for 8711 fixed in 1.4, but in any case, the 
code in trunk is not affected because you already changed it in such a 
way that the problem doesn't exist.  :)

Thanks for checking ...

-- 
Russell Bryant
Software Engineer
Digium, Inc.