[asterisk-dev] Re: [svn-commits] kpfleming: branch 1.4 r49165 - /branches/1.4/channels/chan_zap.c

[Russell Bryant]

----- svn-commits at lists.digium.com wrote:
> Author: kpfleming
> Date: Tue Jan  2 07:59:44 2007
> New Revision: 49165
> 
> URL: http://svn.digium.com/view/asterisk?view=rev&rev=49165
> Log:
> remove comment that is unrelated to this function
> 
> Modified:
>     branches/1.4/channels/chan_zap.c
> 
> Modified: branches/1.4/channels/chan_zap.c
> URL:
> http://svn.digium.com/view/asterisk/branches/1.4/channels/chan_zap.c?view=diff&rev=49165&r1=49164&r2=49165
> ==============================================================================
> --- branches/1.4/channels/chan_zap.c (original)
> +++ branches/1.4/channels/chan_zap.c Tue Jan  2 07:59:44 2007
> @@ -1082,7 +1082,7 @@
>  out:
>  	ast_mutex_unlock(&pvt->lock);
>  
> -	return 0; /* Tell Asterisk not to generate inband indications */
> +	return 0;
>  }

That's not quite true.  The comment was correct.  A non-zero return value from this function would indicate to Asterisk that this channel driver, for whatever reason, would like the core to generate the DTMF tone as inband audio.  So, a return of zero tells the core that the channel driver had its own way of sending the digit.

-- 
Russell Bryant
Software Engineer
Digium, Inc.