[asterisk-dev] Re: [svn-commits] file: trunk r54711 - /trunk/main/manager.c

Kaloyan Kovachev kkovachev at varna.net
Sat Feb 17 04:18:52 MST 2007


while on the subject of commits in revision 54898 "autofallthrough" has been
fixed, but with "write_protect" it is the same:

at line 50
static int write_protect_config = 1;

but at line 2183
write_protect_config = ast_true(ast_variable_retrieve(cfg, "general",
"writeprotect"));

couldn't find any statement about the default value of "writeprotect" and in
/configs/extensions.conf.sample it is set to "no", but i think it is safer to
have the default to "yes".

On Fri, 16 Feb 2007 17:37:53 -0500, Russell Bryant wrote
> Joshua Colp wrote:
> > Russell Bryant wrote:
> >> svn-commits at lists.digium.com wrote:
> >>> Author: file
> >>> Date: Thu Feb 15 18:10:17 2007
> >>> New Revision: 54711
> >>>
> >>> URL: http://svn.digium.com/view/asterisk?view=rev&rev=54711
> >>> Log:
> >>> Properly handle an error result from a manager action. This could 
> >>> have left the action list permanently locked for reading.
> >>
> >> Have you checked the 1.4 branch?  It most likely has the same bug.
> > 
> > I did, it doesn't.
> 
> Oh.  Nevermind.  :)
> 
> -- 
> Russell Bryant
> Software Engineer
> Digium, Inc.



More information about the asterisk-dev mailing list