[asterisk-dev] [Asterisk 0011377]: added a return variable to app_controlplayback that reports the key used to stop playback.

[Johan Wilfer]

Hi,
Qwell submitted this patch from me to trunk. To summarize the feature 
app_controlplayback now
reports the key used to stop playback. This allows the user to have 
multiple stop keys and do all
kind of fancy logic in the dialplan. I for example have one key (*) that 
plays an instruction how to
use the keypad.

Together with this patch I suggested that the original behavior to use * 
and # as fast forward / rewind
is changed. Qwell said that this should be discussed separately so here 
we go :)

My suggestion is to simply default to no forward / rewind key. Because 
if you would like to
use your own logic in the dialplan and don't want to use the forward / 
rewind you still have to provide
two keys for this along with 0 as skip argument to neutralize this default.

Maybe the current default doesn't make sense anyway, and should be 
changed. As stated on voip-info.org:
"Note that as the *** key is on the left and the *#* button is on the 
right of a  telephone keypad, it may make
more sense to swap the default buttons: use *** for rewind and *#* for 
forward."

Comments?
Could we remove these defaults?
/Johan


noreply at bugs.digium.com wrote:
> The following issue has been RESOLVED. 
> ====================================================================== 
> http://bugs.digium.com/view.php?id=11377 
> ====================================================================== 
> Reported By:                johan
> Assigned To:                qwell
> ====================================================================== 
> Project:                    Asterisk
> Issue ID:                   11377
> Category:                   Applications/app_controlplayback
> Reproducibility:            N/A
> Severity:                   feature
> Priority:                   normal
> Status:                     resolved
> Asterisk Version:            SVN 
> SVN Branch (only for SVN checkouts, not tarball releases):  trunk 
> SVN Revision (number only!): 89566 
> Disclaimer on File?:        N/A 
> Resolution:                 fixed
> Fixed in Version:           
> ====================================================================== 
> Date Submitted:             11-26-2007 09:08 CST
> Last Modified:              12-11-2007 15:17 CST
> ====================================================================== 
> Summary:                    added a return variable to app_controlplayback that
> reports the key used to stop playback.
> Description: 
> Previously there have been patches to app_controlplayback that added
> features like multiple skip speeds on different buttons. This patch will
> allow these features to be designed in the users dialplan insted.
>
> When the user stops the playback with one of his stop keys the variable
> CPLAYBACKSTOPKEY is set to indicate which key was used.
>
> By calling app_controlplayback with
> ControlPlayback(ss-noservice,,,,0123456789*#) as an extreme example you can
> do all handling of skipping in the dialplan.
> ====================================================================== 
>
> ---------------------------------------------------------------------- 
>  qwell - 12-11-07 15:17  
> ---------------------------------------------------------------------- 
> I elected to only set the variable when the status is USERSTOPPED.
>
> I also elected not to change the fwd and rev defaults here.  That should
> be opened as a separate bug, and we can discuss the merits of that there. 
>
> Issue History 
> Date Modified   Username       Field                    Change               
> ====================================================================== 
> 12-11-07 15:17  qwell          Status                   new => resolved     
> 12-11-07 15:17  qwell          Resolution               open => fixed       
> 12-11-07 15:17  qwell          Assigned To               => qwell           
> 12-11-07 15:17  qwell          Note Added: 0075238                          
> ======================================================================
>
>