[asterisk-dev] Re: kpfleming: branch 1.2 r43895 - /branches/1.2/cli.c

[Tony Mountifield]

In article <20060928163245.82FABA948E2 at abita.digium.internal>,
 <svn-commits at lists.digium.com> wrote:
> Author: kpfleming
> Date: Thu Sep 28 11:32:44 2006
> New Revision: 43895
> 
> URL: http://svn.digium.com/view/asterisk?rev=43895&view=rev
> Log:
> eliminate compiler warning introduced by recent changes
> 
> Modified:
>     branches/1.2/cli.c
> 
> Modified: branches/1.2/cli.c
> URL: http://svn.digium.com/view/asterisk/branches/1.2/cli.c?rev=43895&r1=43894&r2=43895&view=diff
> ==============================================================================
> --- branches/1.2/cli.c (original)
> +++ branches/1.2/cli.c Thu Sep 28 11:32:44 2006
> @@ -784,7 +784,7 @@
>  		c->fds[0], c->fin & 0x7fffffff, (c->fin & 0x80000000) ? " (DEBUGGED)" : "",
>  		c->fout & 0x7fffffff, (c->fout & 0x80000000) ? " (DEBUGGED)" : "", (long)c->whentohangup,
>  		cdrtime, c->_bridge ? c->_bridge->name : "<none>", ast_bridged_channel(c) ?
> ast_bridged_channel(c)->name : "<none>", 
> -		c->context, c->exten, c->priority, c->callgroup, c->pickupgroup, ( c->appl ? c->appl : "(N/A)" ),
> +		c->context, c->exten, c->priority, (int) c->callgroup, (int) c->pickupgroup, ( c->appl ?

This looks like the wrong way to fix it. Since callgroup and pickupgroup
are now 64-bit values, casting to int will lose 32 bits of information.

Those variables are of type ast_group_t which is "unsigned long long",
so the (int) casts should be removed, and the format specifiers changed
from %d to %llu

Cheers
Tony
-- 
Tony Mountifield
Work: tony at softins.co.uk - http://www.softins.co.uk
Play: tony at mountifield.org - http://tony.mountifield.org