[asterisk-dev] bug #7911

[Steve Hanselman]

Why not do it exactly the same way apache does it?

Saves re-inventing the wheel and it works.

Steve
 

-----Original Message-----
From: asterisk-dev-bounces at lists.digium.com
[mailto:asterisk-dev-bounces at lists.digium.com] On Behalf Of Steve Davies
Sent: 11 September 2006 14:40
To: Asterisk Developers Mailing List
Subject: Re: [asterisk-dev] bug #7911

On 9/11/06, Tzafrir Cohen <tzafrir.cohen at xorcom.com> wrote:
>
> That is:
>
> the change you suggest would break:
>
>   Playback(/var/lib/asterisk/sounds/digits/1)
>
> This works with the current code. Not just:
>
>   Playback(digits/1)
>
> This is what I meant by "assuming a base directory".

Fair comment, thanks for clarifying that, but (IMHO) if you specify a
fully qualified pathname as you do in the line above, that is exactly
what you should get... This would allow a fairly intuitive means of
choosing a soundfile from the dialplan without changing the current base
language...

For example, all of the following would be legal (assuming the validity
of a $LANG variable or equivalent:

  Playback(/var/lib/asterisk/sounds/digits/1) - US/default (ignores
current LANG)
  Playback(/var/lib/asterisk/sounds/uk/digits/1) - UK (ignores current
LANG)
  Playback(/var/lib/asterisk/sounds/${LANG}/digits/1) - Current base
language
  Playback(${LANG}/digits/1) - Current base language, no fallback to US
files
  Playback(digits/1) - Current base language, with fallback to US file

ie... you would get what you asked for :)

> The code is already there. Check file.c . Please suggest a patch.

Touche! I'll take a look :)

Steve
_______________________________________________
--Bandwidth and Colocation provided by Easynews.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev


The information contained in this email is intended for the personal and confidential use
of the addressee only. It may also be privileged information. If you are not the intended
recipient then you are hereby notified that you have received this document in error and
that any review, distribution or copying of this document is strictly prohibited. If you have 
received  this communication in error, please notify Brendata immediately on: 

+44 (0)1268 466100, or email 'technical at brendata.co.uk' 

Brendata (UK) Ltd
Nevendon Hall, Nevendon Road, Basildon, Essex. SS13 1BX  UK
Registered Office as above. Registered in England No. 2764339

See our current vacancies at www.brendata.co.uk