[asterisk-dev] Re: [svn-commits] oej: trunk r46392 - /trunk/channels/chan_sip.c

[Martin Vít]

Hello,

I'had some times ago (with 1.2) issues with gxp2000 that sip qualify was 
about 8ms but some actions as invite, reinvite tooks 50ms and sometime 
100-200ms. But when qualify was low it drops packets because of timeout. 
Solution was turn off qualify. Maybe there should be option how qualify 
affects T1 (fixed, based on qualify or so) Whats your opinion?

svn-commits at lists.digium.com wrote:
> Author: oej
> Date: Sun Oct 29 02:15:26 2006
> New Revision: 46392
>
> URL: http://svn.digium.com/view/asterisk?rev=46392&view=rev
> Log:
> maxtime is not needed any more now that we actually set the T1 timer
> based on the qualify result.
>
> Modified:
>     trunk/channels/chan_sip.c
>
> Modified: trunk/channels/chan_sip.c
> URL: http://svn.digium.com/view/asterisk/trunk/channels/chan_sip.c?rev=46392&r1=46391&r2=46392&view=diff
> ==============================================================================
> --- trunk/channels/chan_sip.c (original)
> +++ trunk/channels/chan_sip.c Sun Oct 29 02:15:26 2006
> @@ -970,7 +970,6 @@
>  							XXX BUG!!! XXX
>  						*/
>  	
> -	int maxtime;				/*!< Max time for first response */
>  	int initid;				/*!< Auto-congest ID if appropriate (scheduler) */
>  	int autokillid;				/*!< Auto-kill ID (scheduler) */
>  	enum transfermodes allowtransfer;	/*!< REFER: restriction scheme */
> @@ -2711,7 +2710,6 @@
>  		ast_string_field_set(dialog, fromdomain, peer->fromdomain);
>  	if (!ast_strlen_zero(peer->fromuser))
>  		ast_string_field_set(dialog, fromuser, peer->fromuser);
> -	dialog->maxtime = peer->maxms;
>  	dialog->callgroup = peer->callgroup;
>  	dialog->pickupgroup = peer->pickupgroup;
>  	dialog->allowtransfer = peer->allowtransfer;
> @@ -2877,11 +2875,7 @@
>  		if (option_debug)
>  			ast_log(LOG_DEBUG,"Our T38 capability (%d), joint T38 capability (%d)\n", p->t38.capability, p->t38.jointcapability);
>  		transmit_invite(p, SIP_INVITE, 1, 2);
> -		if (p->maxtime)
> -			/* Initialize auto-congest time */
> -			p->initid = ast_sched_add(sched, p->maxtime * 4, auto_congest, p);
> -		else 
> -			p->initid = ast_sched_add(sched, SIP_TRANS_TIMEOUT, auto_congest, p);
> +		p->initid = ast_sched_add(sched, SIP_TRANS_TIMEOUT, auto_congest, p);
>  	}
>  	return res;
>  }
>
> _______________________________________________
> --Bandwidth and Colocation provided by Easynews.com --
>
> svn-commits mailing list
> To UNSUBSCRIBE or update options visit:
>    http://lists.digium.com/mailman/listinfo/svn-commits
>
>   


-- 
Martin Vít
LAM plus s.r.o.
http://www.vasesit.cz/
mobil: 605 267 610