[asterisk-dev] Re: [asterisk-commits] russell: trunk r48019 - in /trunk/include/asterisk: threadstorage.h utils.h

Kevin P. Fleming kpfleming at digium.com
Tue Nov 28 16:56:23 MST 2006


Luigi Rizzo wrote:
> On Sun, Nov 26, 2006 at 06:55:34AM -0000, asterisk-commits at lists.digium.com wrote:
>> Author: russell
>> Date: Sun Nov 26 00:55:33 2006
>> New Revision: 48019
>>
>> URL: http://svn.digium.com/view/asterisk?view=rev&rev=48019
>> Log:
>> - Add some comments on thread storage with a brief explanation of what it is
>>   as well as what the motivation is for using it.
>> - Add a comment by the declaration of ast_inet_ntoa() noting that this function
>>   is not reentrant, and the result of a previous call to the function is no
>>   longer valid after calling it again.
> 
> thanks - much appreciated.

I'll be pedantic here... 'reentrant' is not the correct word to use,
since this function cannot be convinced to call itself (so there is no
're-entry' into the same function).

I don't know that there is a better word, but I'm hesitant to leave it
this way and have someone look at the code and wonder how anyone could
have thought it WAS reentrant :-) There are other functions in the
standard C library that have similar behavior, so we may be able to
steal some language from their man pages.


More information about the asterisk-dev mailing list