[asterisk-dev] h323 compilation errors

[Derek Smithies]

Hi,

On Fri, 19 May 2006, Kevin P. Fleming wrote:

> Wilmar Campos wrote:
> 
> > ast_h323.cxx:1:1: warning: "_GNU_SOURCE" redefined
> > <command line>:4:1: warning: this is the location of the previous
> > definition
> 
> Where does this say 'error'? This is a compiler warning. You can ignore it.

- Did I miss something, or is there a basic philosophy problem here?

You have all heard the saying, "with many eyes, all bugs  become shallow".
The compiler is one set of eyes.
 The compiler's eyes are concerned about something - so why not fix it?

Is this the philosophy of the asterisk group - ignore warnings?
 Surely, warnings are often indicative of trouble ahead?

My view is that stable production quality code will compile with correctly
with the flags
   -Wall -Werror.


Derek.


-- 
Derek Smithies Ph.D.                 Any fool can write code that 
IndraNet Technologies Ltd.                a computer can understand.        
Email: derek at indranet.co.nz         Good programmers write code 
ph +64 3 365 6485                          that humans can understand.
Web: http://www.indranet-technologies.com/            Martin Fowler