[asterisk-dev] T38 Passthrough in chan_sip.c

[Olle E Johansson]

18 mar 2006 kl. 08.56 skrev George Pajari:

> I'm trying to figure out why the T38 passthrough code generates  
> warnings of the form "The other side of the bridge don't have udptl  
> struct" and my investigations of the code suggest that the udptl  
> structure is not allocated because the SIP channel does not have  
> the flag SIP_PAGE2_T38SUPPORT_UDPTL set.
>
> But SIP_PAGE2_T38SUPPORT_UDPTL is defined with value 0:
>
> #define SIP_PAGE2_T38SUPPORT_UDPTL      (0 << 15)
>
> so how can this flag ever be set?
>
> Will not the test:
>
> ast_test_flag(&p->t38.t38support, SIP_PAGE2_T38SUPPORT_UDPTL)
>
> always be false?
>
> What am I missing here?
>
Well, testing shows that you are not missing anything.

Thanks for the feedback and the persistance!
Will fix this in both test-this-branch and the t38passthrough branch.

Tests are important!

/O