[asterisk-dev] Re: agi segfaults 1.2.9.1

[Julian Lyndon-Smith]

Kevin,

Slow down - it was meant to be read with a smiley. It *is* impossible to 
manually go through all possible combinations of parameters to make sure 
that they all work.

In regards to the AddQueueMember, I simply forgot to add @context to the 
end of the device name. I don't think that this should cause a segfault. 
On the other hand, I wouldn't expect you to be testing for 
@averyververylongcontextthatcouldbe100000000000millioncharacterslong either.

Julian

Kevin P. Fleming wrote:
> ----- Julian Lyndon-Smith <asterisk at dotr.com> wrote:
>> I'm sure that part of Kevin's email was cut off, and that he meant to
>>
>> say in addition was "and we'd like to be made aware of them so that
>> they 
>> can be fixed in order to make asterisk an even more reliable system"
> 
> No, it was not. It is not possible to completely validate every set of parameters sent to every single application/function/AGI command/etc. in Asterisk. Even if it was possible, it's not worth the effort or the time/memory/etc. cost it would put on the users of Asterisk.
> 
>> having reported bug #7354 earlier today, a crash when invalid
>> parameters 
>> are passed to AddQueueMember
> 
> Invalid parameters are one thing, no parameter at all (when one is clearly documented to be required) is something else entirely. With that said, no matter how much you want to try, there is no amount of code we can put into things like AddQueueMember that will always guarantee that nothing bad will happen if you specify invalid parameters.
>