[asterisk-dev] include/asterisk/sha1.h and sha1.c

Steve Underwood steveu at coppice.org
Sat Feb 4 04:51:53 MST 2006

Luigi Rizzo wrote:

>this file, and the matching sha1.c, have trailing ^M
>on all lines. ^M
>they are very annoying^M
>aren't they?^M
>would it be possible to redo the commit using proper formatting ?^M
>besides, the use of int_least16_t in the code is really a^M
>gratuitous source of incompatibility.^M
>The way it is used in the code, the only variable with that type,^M
>Message_Block_Index, has values between 0 and 63 so any integer^M
>type will be ok...^M
Whilst the ^Ms are a pain, why is the use of standardised data types 
like int_least16_t considered bad?


More information about the asterisk-dev mailing list