[asterisk-dev] Re: [svn-commits]file: branch1.4 r319- /branches/1.4/asterisk-ooh323c/src/chan_h323.c

[Dan Austin]

Russell wrote:
> Dan Austin wrote:
>> Should the ast_channel_allow strip/replace spaces in a requested
channel
>> name, or should chan_ooh323 pick a better identifier?
>> 
>> I'd vote for the former in case another channel chooses a similar
>> approach, but I'm not sure I care too much either way.

> I would say that it just needs to use a better identifier.  It should
just 
> follow the convention used in other modules, where it uses a peer name
from the 
> configuration if available, or the host name of the calling peer,
followed by a 
> random number.  You might want to look into some other modules to
review exactly 
> what is done.  Also, I noticed that it uses rand(), and if this is
getting 
> worked on anyway, it should be changed to ast_random().
I'll give that a shot.  I remember that the channels peer matching logic
has some quirks, which, if they still exist should be addressed as well.
I'll also tackle the rand() issue.

After I posted the patch I realized that there may be a problem with the
result.  The section modified used state to see if the call was
established,
and the last patch didn't really take that into consideration.  I've
made
test calls with the updated code, but there might be a failure mode I
haven't uncovered yet.  I'll look that over tomorrow as well.

Dan