[asterisk-dev] -netsec sip_destroy_hook annoyance, libmidcom proposed change

[Peter Beckman]

On Mon, 4 Dec 2006, Kevin P. Fleming wrote:

> Peter Beckman wrote:
>>  I'm sure 1.4-netsec will be released; at least I haven't heard any
>>  rumblings that it will/may be discontinued.  Ranch does nothing special
>>  other than implement MIDCOM firewall gunk.
>
> There is not currently a timeframe for a 1.4 netsec-enabled release;
> there is work being done to bring the code up to our standards and merge
> it properly, and when that happens it will be a native feature of 1.4,
> not a separate branch.

  So, as for my proposed changes to the code, is there a "yes" for a patch?

diff -u libmidcom-0.2.0/res_netsec.c libmidcom-0.2.0-beckman/res_netsec.c
--- libmidcom-0.2.0/res_netsec.c        2006-06-15 16:55:21.000000000 -0400
+++ libmidcom-0.2.0-beckman/res_netsec.c        2006-12-02 16:24:33.000000000 -0500
@@ -600,8 +600,8 @@
    struct midcom_rule *r = NULL;

    if (!midcom_enabled) {
-    ast_log(LOG_ERROR, "Midcom: Module not enabled\n");
-    if (option_verbose > 1)
+    ast_log(LOG_DEBUG, "Midcom: Module not enabled\n");
+    if (option_verbose > 300)
        ast_verbose("Midcom: Module currently disabled\n");
      return 1;
    }
@@ -679,9 +679,9 @@
    struct midcom_rule *r = NULL;

    if (!midcom_enabled) {
-    ast_log(LOG_ERROR, "Midcom: Module not enabled\n");
-    if (option_verbose > 1)
-       ast_verbose("Midcom: Module currently disabled\n");
+    ast_log(LOG_DEBUG, "Midcom: Module not enabled\n");
+    if (option_verbose > 300)
+      ast_verbose("Midcom: Module currently disabled\n");
      return 1;
    }

@@ -797,8 +797,8 @@
    int codec = 0;

    if (!midcom_enabled) {
-    ast_log(LOG_ERROR, "Midcom: Module not enabled\n");
-    if (option_verbose > 1)
+    ast_log(LOG_DEBUG, "Midcom: Module not enabled\n");
+    if (option_verbose > 300)
        ast_verbose("Midcom: Module currently disabled\n");
      return 1;
    }
@@ -886,8 +886,8 @@
    char *username = NULL;

    if (!midcom_enabled) {
-    ast_log(LOG_ERROR, "Midcom: Module not enabled\n");
-    if (option_verbose > 1)
+    ast_log(LOG_DEBUG, "Midcom: Module not enabled\n");
+    if (option_verbose > 300)
        ast_verbose("Midcom: Module currently disabled\n");
      return 1;
    }
@@ -1055,8 +1055,8 @@
    char *username=NULL;

    if (!midcom_enabled) {
-    ast_log(LOG_ERROR, "Midcom: Module not enabled\n");
-    if (option_verbose > 1)
+    ast_log(LOG_DEBUG, "Midcom: Module not enabled\n");
+    if (option_verbose > 300)
        ast_verbose("Midcom: Module currently disabled\n");
      return 1;
    }

Beckman
---------------------------------------------------------------------------
Peter Beckman                                                  Internet Guy
beckman at purplecow.com                             http://www.purplecow.com/
---------------------------------------------------------------------------