[asterisk-dev] Another correction on res_features.c

[Dov Bigio]

Hi Anton,

My changes check if variable f is being used before freeing it.

Without this fix, I was having lots of server downtimes when my queue agents
where doing atxtransfers using the 1 key (that I defined in features.conf).

Regards
Dov

-----Original Message-----
From: Anton [mailto:anton.vazir at gmail.com] 
Sent: segunda-feira, 17 de abril de 2006 11:16
To: Dov Bigio; Asterisk Developers Mailing List
Subject: Re: [asterisk-dev] Another correction on res_features.c

Hi Dov,

What that corrections you posted does exactly?

Sincerely,
Anton.

On 17 April 2006 18:46, Dov Bigio wrote:
> Another change that was made on my Asterisk 1.2.6 and helped a lot...
>
>
>
>
>
> ---------------------------------------------------------
>-----------------------
>
> +++ res_features.c      2006-04-13 17:45:43.000000000
> -0300 @@ -1439,7 +1439,16 @@
>                         if (res >=
> FEATURE_RETURN_PASSDIGITS) { res = 0;
>                         } else {
> -                               ast_frfree(f);
> +                               if (f->mallocd > 10 ||
> f->mallocd < -10) { +                               }
> else if (f->frametype > 100 || f->frametype < -100) { +  
>                             } else if ((f->mallocd &
> AST_MALLOCD_DATA) && (f->data) && (f->offset < -10000 ||
> f->offset > 10000)) { +                               }
> else {
> +                                       ast_frfree(f);
> +                               }
>                                 break;
>                         }
>                         hasfeatures =
> !ast_strlen_zero(chan_featurecode) ||
> !ast_strlen_zero(peer_featurecode);