[Asterisk-Dev] say.c cleanup

Luigi Rizzo rizzo at icir.org
Wed Jul 13 08:09:03 MST 2005


On Wed, Jul 13, 2005 at 08:35:53AM -0500, Kevin P. Fleming wrote:
> Luigi Rizzo wrote:
> 
> > as you see, if ast_streamfile() fails, ast_stopstream() is not called.
> > Can someone explain which way is correct or whether they
> > are equivalent ?
> 
> There is no harm in calling ast_stopstream() if ast_streamfile() failed, 
> since chan->stream will be empty. However, there is no value in calling 
> in that situation either :-)

ok a related question is, why the code wants both descriptors > -1
to call ast_waitstream_full() ? The function seems to accept all
combinations...

Nevertheless, i will start impementing the function as it is and
fix it later...

        cheers
        luigi



More information about the asterisk-dev mailing list