[Asterisk-Dev] Patching flags to bitfield structs

creslin at digium.com creslin at digium.com
Thu Jan 20 14:29:17 MST 2005


On Thu, Jan 20, 2005 at 02:49:51PM -0500, Russell Bryant wrote:
> | What I proposed to the OP was that he produce a sample conversion of
> one of the
> | more complicated modules (chan_sip) so that everyone can see what the
> | actual code would look like, rather than trying to get assent/approval
> | for something that hasn't been seen yet.
> 
> I agree.  This is the only way that this will ever happen.  A module (I
> second the reccomendation for chan_sip) needs to be converted and placed
> on the bug tracker.  I haven't really heard a convincing argument for
> keeping the macros so I'd like to see this discussion continued there so
> a decision can be made.

If anybody's looking for a project, I know that chan_zap.c has a lot of fields
that could be converted over to using int variable_name:1 style flags.  I've
thought a few times about doing it, but just haven't had time to yet.  It also
might be a little less of a moving target than chan_sip.c to work on.

Matthew Fredrickson



More information about the asterisk-dev mailing list