[Asterisk-Dev] any reason for #define FREE in the code ?

Luigi Rizzo rizzo at icir.org
Wed Dec 28 16:54:40 MST 2005


On Wed, Dec 28, 2005 at 05:04:03PM -0600, Kevin P. Fleming wrote:
> Luigi Rizzo wrote:
> 
> > ok but then i'd rather define the wrapper globally e.g. ast_free()
> > and let those function call the wrapper.
> > Even with the current solution you still don't get to see
> > the __FILE__ and __LINE__ of the "calling" function,
> > just those of the wrapper, which doesn't help too much.
> 
> I would agree with the latter part of your statement, but I don't see 
> much value in the first part. There is no reason to force every other 
> module to have to use ast_free() (or document when it is necessary and 
> when it isn't).
> 
> With so few calls to FREE, my personal opinion is that this doesn't even 
> warrant the time we've already spent discussing it :-)

you are right. Back to the real issues, such as
	http://bugs.digium.com/view.php?id=4584

:)
cheers
luigi



More information about the asterisk-dev mailing list