[Asterisk-Dev] Bug in chan_zap.c

[Joel Daniels]

Ooops.  I have a slight correction to my previous email.  I said "everywhere
else in this function there is a size of 2400 + 680", I meant "2400 + 680 +
READ_SIZE * 4".
   - Joel Daniels
----- Original Message ----- 
From: "Joel Daniels" <joeld at invtools.com>
To: "Asterisk Developers Mailing List" <asterisk-dev at lists.digium.com>
Sent: Monday, November 29, 2004 10:49 AM
Subject: [Asterisk-Dev] Bug in chan_zap.c


> Line 1475 of chan_zap.c (Inside function zt_callwait) says:
>
>    memset(p->cidspill, 0x7f, 2400 + 600 + READ_SIZE * 4)
>
> I don't understand hardly any of the code in chan_zap.c very well, however it
> seems odd to me that on this line there is a size of 2400 + 600 + READ_SIZE *
> 4, and every where else in this function there is a size of 2400 + 680.  Is
> this a bug, or is there really a reason why the last 80 bytes of this buffer
> are not being silenced?
>
> Also why are we using READ_SIZE * 4.  Will this create problems if I change
> READ_SIZE to be 16 instead of 160?
>
> If this is a but I'll be glad to put into mantis, if that is the correct
> protocol, but I want to be sure that it is a bug first.
>
>    - Joel Daniels
>
> _______________________________________________
> Asterisk-Dev mailing list
> Asterisk-Dev at lists.digium.com
> http://lists.digium.com/mailman/listinfo/asterisk-dev
> To UNSUBSCRIBE or update options visit:
>    http://lists.digium.com/mailman/listinfo/asterisk-dev
>
>
> !DSPAM:41ab52d6208891434915289!
>
>
>