[Asterisk-Dev] Re: [Asterisk-cvs] asterisk pbx.c,1.111,1.112

Conroy, Lawrence (SMTP) lwc at roke.co.uk
Sun Apr 18 04:18:49 MST 2004


Hi Folks,
   Is there a particular reason why all extension matching should be 
case sensitive?
The bug seems to have come about as Mark didn't want to use a different 
letter for
Absolute and Response timeouts.

Are we so short on letters that we need all users to go through and 
check their
extensions.conf? The bugfix certainly works, but is a bit severe, IMHO.

(Of course, the log message is reversed, but documentation doesn't 
count :).

all the best,
   Lawrence

Begin forwarded message:

> From: citats at lists.digium.com
> Date: 18 April 2004 7:47:17 am BST
> To: asterisk-cvs at lists.digium.com
> Subject: [Asterisk-cvs] asterisk pbx.c,1.111,1.112
>
> Update of /usr/cvsroot/asterisk
> In directory mongoose.digium.com:/tmp/cvs-serv16996
>
> Modified Files:
> 	pbx.c
> Log Message:
> Make extension matching non case sensitive.  So 'T' and 't' are
> different extensions (bug 1327)
>
>
> Index: pbx.c
> ===================================================================
> RCS file: /usr/cvsroot/asterisk/pbx.c,v
> retrieving revision 1.111
> retrieving revision 1.112
> diff -u -d -r1.111 -r1.112
> --- pbx.c	6 Apr 2004 22:17:31 -0000	1.111
> +++ pbx.c	18 Apr 2004 05:50:55 -0000	1.112
> @@ -3682,7 +3682,7 @@
>  	}
>  	e = con->root;
>  	while(e) {
> -		res= strcasecmp(e->exten, extension);
> +		res= strcmp(e->exten, extension);
>  		if (!res) {
>  			if (!e->matchcid && !tmp->matchcid)
>  				res = 0;
>
> _______________________________________________
> Asterisk-Cvs mailing list
> Asterisk-Cvs at lists.digium.com
> http://lists.digium.com/mailman/listinfo/asterisk-cvs
>

-- 

Visit our website at www.roke.co.uk

Registered Office: Roke Manor Research Ltd, Siemens House, Oldbury, Bracknell,
Berkshire. RG12 8FZ

The information contained in this e-mail and any attachments is confidential to
Roke Manor Research Ltd and must not be passed to any third party without
permission. This communication is for information only and shall not create or
change any contractual relationship.




More information about the asterisk-dev mailing list