[Asterisk-Dev] Crappy New Year - AGI is b0rked
critch at basesys.com
Wed Dec 31 21:59:41 MST 2003
On Wed, 2003-12-31 at 19:01, Paul Liew wrote:
> > I remember having problems with AGI after I applied PHM's patch which
> since has been comitted to CVS. I'm not sure what it was supposted to fix,
> but it gave me some problems.
> > This will take it back out:
> > --- app_agi.c.prev Thu Dec 25 19:11:35 2003
> > +++ app_agi.c Thu Dec 25 19:14:27 2003
> > @@ -167,10 +167,6 @@
> > /* close what we're not using in the parent */
> > close(toast);
> > close(fromast);
> > -
> > - // [PHM 12/18/03]
> > - close(audio);
> > -
> > *opid = pid;
> > return 0;
> > Kevin
> This definitely causes agi scripts to break - its ok for eagi, because the
> audio pipe is open, in agi its not, so closing a non-existing fd will crash.
> So uncomment that "close" bit and it should be ok. Its bug 698 but its
> closed, can someone at digium re-open, and patch it with a check for the fd
> before closing it? Thanks.
looks like a commit was just made that conditionally closes the fd now.
Looks like it should be done. Thanks Mark.
Steven Critchfield <critch at basesys.com>
More information about the asterisk-dev