<p>Jenkins2 <strong>merged</strong> this change.</p><p><a href="https://gerrit.asterisk.org/9166">View Change</a></p><div style="white-space:pre-wrap">Approvals:
Kevin Harwell: Looks good to me, approved
Jenkins2: Approved for Submit
</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">AST-2018-008: Fix enumeration of endpoints from ACL rejected addresses.<br><br>Updated the tests/channels/pjsip/acl_call test to check for the new<br>response message that does not give away valid endpoints.<br><br>* Changed expected ACL rejection response code from 403 forbidden to 401<br>unauthorized.<br><br>* pjsip.conf: Enabled SIP message debug in the logs.<br><br>* test-config.yaml: Added missing test dependencies.<br><br>ASTERISK-27818<br><br>Change-Id: Id3c46ac3329e1447b396cf44770202b003aa3a9a<br>---<br>M tests/channels/pjsip/acl_call/configs/ast1/pjsip.conf<br>M tests/channels/pjsip/acl_call/sipp/testsip1-failure.xml<br>M tests/channels/pjsip/acl_call/sipp/testsip2-failure.xml<br>M tests/channels/pjsip/acl_call/sipp/testsip3-failure.xml<br>M tests/channels/pjsip/acl_call/sipp/testsip4-failure.xml<br>M tests/channels/pjsip/acl_call/sipp/testsip5-failure.xml<br>M tests/channels/pjsip/acl_call/test-config.yaml<br>7 files changed, 10 insertions(+), 5 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">diff --git a/tests/channels/pjsip/acl_call/configs/ast1/pjsip.conf b/tests/channels/pjsip/acl_call/configs/ast1/pjsip.conf<br>index a6e24bc..94fd3ae 100644<br>--- a/tests/channels/pjsip/acl_call/configs/ast1/pjsip.conf<br>+++ b/tests/channels/pjsip/acl_call/configs/ast1/pjsip.conf<br>@@ -1,3 +1,7 @@<br>+[global]<br>+type=global<br>+debug=yes<br>+<br> [local]<br> type=transport<br> protocol=udp<br>diff --git a/tests/channels/pjsip/acl_call/sipp/testsip1-failure.xml b/tests/channels/pjsip/acl_call/sipp/testsip1-failure.xml<br>index 4bb8104..1391782 100644<br>--- a/tests/channels/pjsip/acl_call/sipp/testsip1-failure.xml<br>+++ b/tests/channels/pjsip/acl_call/sipp/testsip1-failure.xml<br>@@ -52,7 +52,7 @@<br> optional="true"><br> </recv><br> <br>- <recv response="403"><br>+ <recv response="401"><br> </recv><br> <br> <send><br>diff --git a/tests/channels/pjsip/acl_call/sipp/testsip2-failure.xml b/tests/channels/pjsip/acl_call/sipp/testsip2-failure.xml<br>index f10dfd2..6a03cdd 100644<br>--- a/tests/channels/pjsip/acl_call/sipp/testsip2-failure.xml<br>+++ b/tests/channels/pjsip/acl_call/sipp/testsip2-failure.xml<br>@@ -52,7 +52,7 @@<br> optional="true"><br> </recv><br> <br>- <recv response="403"><br>+ <recv response="401"><br> </recv><br> <br> <send><br>diff --git a/tests/channels/pjsip/acl_call/sipp/testsip3-failure.xml b/tests/channels/pjsip/acl_call/sipp/testsip3-failure.xml<br>index f3541dc..f96e19b 100644<br>--- a/tests/channels/pjsip/acl_call/sipp/testsip3-failure.xml<br>+++ b/tests/channels/pjsip/acl_call/sipp/testsip3-failure.xml<br>@@ -52,7 +52,7 @@<br> optional="true"><br> </recv><br> <br>- <recv response="403"><br>+ <recv response="401"><br> </recv><br> <br> <send><br>diff --git a/tests/channels/pjsip/acl_call/sipp/testsip4-failure.xml b/tests/channels/pjsip/acl_call/sipp/testsip4-failure.xml<br>index 3efa4f7..0fecc2f 100644<br>--- a/tests/channels/pjsip/acl_call/sipp/testsip4-failure.xml<br>+++ b/tests/channels/pjsip/acl_call/sipp/testsip4-failure.xml<br>@@ -52,7 +52,7 @@<br> optional="true"><br> </recv><br> <br>- <recv response="403"><br>+ <recv response="401"><br> </recv><br> <br> <send><br>diff --git a/tests/channels/pjsip/acl_call/sipp/testsip5-failure.xml b/tests/channels/pjsip/acl_call/sipp/testsip5-failure.xml<br>index 8340fc0..39c14be 100644<br>--- a/tests/channels/pjsip/acl_call/sipp/testsip5-failure.xml<br>+++ b/tests/channels/pjsip/acl_call/sipp/testsip5-failure.xml<br>@@ -52,7 +52,7 @@<br> optional="true"><br> </recv><br> <br>- <recv response="403"><br>+ <recv response="401"><br> </recv><br> <br> <send><br>diff --git a/tests/channels/pjsip/acl_call/test-config.yaml b/tests/channels/pjsip/acl_call/test-config.yaml<br>index 0573828..dd51ce7 100644<br>--- a/tests/channels/pjsip/acl_call/test-config.yaml<br>+++ b/tests/channels/pjsip/acl_call/test-config.yaml<br>@@ -11,6 +11,7 @@<br> - python : 'twisted'<br> - python : 'starpy'<br> - app : 'sipp'<br>+ - asterisk : 'res_config_sqlite3'<br> - asterisk : 'res_pjsip'<br> tags:<br> - pjsip<br></pre><p>To view, visit <a href="https://gerrit.asterisk.org/9166">change 9166</a>. To unsubscribe, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/9166"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: testsuite </div>
<div style="display:none"> Gerrit-Branch: 13.21 </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: Id3c46ac3329e1447b396cf44770202b003aa3a9a </div>
<div style="display:none"> Gerrit-Change-Number: 9166 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Richard Mudgett <rmudgett@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins2 </div>
<div style="display:none"> Gerrit-Reviewer: Kevin Harwell <kharwell@digium.com> </div>