<p>Joshua Colp <strong>merged</strong> this change.</p><p><a href="https://gerrit.asterisk.org/6680">View Change</a></p><div style="white-space:pre-wrap">Approvals:
Joshua Colp: Looks good to me, but someone else must approve; Approved for Submit
George Joseph: Looks good to me, approved
</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">tcptls: Do not re-bind to wildcard on client creation.<br><br>Since ASTERISK-26922, this issue affected only those chan_sip which were<br>* enabled for dual-stack (bindaddr=::), and<br>* enabled for TCP (tcpenable=yes) and/or TLS (tlsenable=yes), and<br>* tried to register and/or invite a IPv4-only service,<br>* via TCP and/or TLS.<br>Now, ast_tcptls_client_create does not re-bind to [::] anymore.<br><br>ASTERISK-27324 #close<br><br>Change-Id: I4b242837bdeb1ec7130dc82505c6180a946fd9b5<br>---<br>M main/tcptls.c<br>1 file changed, 2 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">diff --git a/main/tcptls.c b/main/tcptls.c<br>index ebe86f3..dbcff9d 100644<br>--- a/main/tcptls.c<br>+++ b/main/tcptls.c<br>@@ -572,7 +572,8 @@<br> <br> /* if a local address was specified, bind to it so the connection will<br> originate from the desired address */<br>- if (!ast_sockaddr_isnull(&desc->local_address)) {<br>+ if (!ast_sockaddr_isnull(&desc->local_address) &&<br>+ !ast_sockaddr_is_any(&desc->local_address)) {<br> setsockopt(desc->accept_fd, SOL_SOCKET, SO_REUSEADDR, &x, sizeof(x));<br> if (ast_bind(desc->accept_fd, &desc->local_address)) {<br> ast_log(LOG_ERROR, "Unable to bind %s to %s: %s\n",<br></pre><p>To view, visit <a href="https://gerrit.asterisk.org/6680">change 6680</a>. To unsubscribe, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/6680"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: I4b242837bdeb1ec7130dc82505c6180a946fd9b5 </div>
<div style="display:none"> Gerrit-Change-Number: 6680 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Alexander Traud <pabstraud@compuserve.com> </div>
<div style="display:none"> Gerrit-Reviewer: Alexander Traud <pabstraud@compuserve.com> </div>
<div style="display:none"> Gerrit-Reviewer: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins2 </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@digium.com> </div>